Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change linter to Ruff #21

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Change linter to Ruff #21

merged 1 commit into from
Jan 23, 2025

Conversation

Schamper
Copy link
Member

Closes #20

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 65.27778% with 25 lines in your changes missing coverage. Please review.

Project coverage is 73.47%. Comparing base (c38995e) to head (44880b8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/thumbcache/tools/utils.py 0.00% 7 Missing ⚠️
dissect/thumbcache/tools/extract_images.py 0.00% 6 Missing ⚠️
dissect/thumbcache/tools/extract_with_index.py 0.00% 6 Missing ⚠️
dissect/thumbcache/index.py 90.47% 2 Missing ⚠️
dissect/thumbcache/thumbcache.py 66.66% 2 Missing ⚠️
dissect/thumbcache/thumbcache_file.py 94.44% 1 Missing ⚠️
dissect/thumbcache/util.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   76.99%   73.47%   -3.53%     
==========================================
  Files          10       10              
  Lines         313      328      +15     
==========================================
  Hits          241      241              
- Misses         72       87      +15     
Flag Coverage Δ
unittests 73.47% <65.27%> (-3.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 6c81fb0 into main Jan 23, 2025
18 of 20 checks passed
@Schamper Schamper deleted the ruff branch January 23, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change linter to Ruff
2 participants