Move the selection between the native and Python implementations of lzo and lz4 to dissect.util #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on fox-it/dissect.util#51 |
Schamper
requested changes
Jul 19, 2024
pyrco
force-pushed
the
move-lzo-lz4-selection-to-dissect.util
branch
from
fe41cfd to
17f950b
Compare
Schamper
requested changes
Jul 25, 2024
pyrco
force-pushed
the
move-lzo-lz4-selection-to-dissect.util
branch
from
17f950b to
37aaff2
Compare
Schamper
previously approved these changes
Jul 26, 2024
…zo and lz4 to dissect.util
pyrco
force-pushed
the
move-lzo-lz4-selection-to-dissect.util
branch
from
37aaff2 to
3812e0f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 87.06% 86.50% -0.57%
==========================================
Files 5 5
Lines 371 363 -8
==========================================
- Hits 323 314 -9
- Misses 48 49 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.