Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SyntaxWarning in lnk_def #34

Merged

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Sep 9, 2024

This PR fixes a SyntaxWarning by properly escaping a comment inside the lnk_def variable.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.43%. Comparing base (2792229) to head (228ba16).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   70.43%   70.43%           
=======================================
  Files           4        4           
  Lines         301      301           
=======================================
  Hits          212      212           
  Misses         89       89           
Flag Coverage Δ
unittests 70.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 975a812 into fox-it:main Sep 9, 2024
18 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/syntaxwarning-escape-sequence-lnk branch September 9, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants