-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caching to Secure lookup #35
Conversation
By the way, I thought about this and I think if Acquire/Velo would collect the Created a ticket for Acquire: fox-it/acquire#180 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 87.43% 87.45% +0.02%
==========================================
Files 11 11
Lines 1234 1236 +2
==========================================
+ Hits 1079 1081 +2
Misses 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
After having profiled the MFT code it became apparent that the
secure.lookup
insideget_owner_and_group
is the culprit. See image below.I have compared the following situations:
get_owner_and_group
calllru_cache
toself.lookup
Which yields the following results:
Here we can see an improvement of 430% by adding caching.
Steps to create the image: