Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move VMA and XVA to dissect.archive #46

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Move VMA and XVA to dissect.archive #46

merged 3 commits into from
Nov 7, 2024

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Nov 6, 2024

@Schamper Schamper requested a review from twiggler November 6, 2024 13:43
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.54%. Comparing base (8ad6252) to head (a7c2cd2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   63.11%   66.54%   +3.43%     
==========================================
  Files          27       23       -4     
  Lines        2375     1991     -384     
==========================================
- Hits         1499     1325     -174     
+ Misses        876      666     -210     
Flag Coverage Δ
unittests 66.54% <ø> (+3.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper changed the title Move VMA to dissect.archive Move VMA and XVA to dissect.archive Nov 6, 2024
@twiggler twiggler self-requested a review November 6, 2024 14:45
Copy link
Contributor

@twiggler twiggler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't project.scripts of pyproject.toml be adjusted?

@Schamper Schamper requested a review from twiggler November 6, 2024 15:45
@Schamper
Copy link
Member Author

Schamper commented Nov 6, 2024

Good point, fixed

@Schamper Schamper merged commit c3c2bb1 into main Nov 7, 2024
20 checks passed
@Schamper Schamper deleted the move-vma branch November 7, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants