Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Veeam Backup files (VBK) #31

Closed
wants to merge 6 commits into from
Closed

Add support for Veeam Backup files (VBK) #31

wants to merge 6 commits into from

Conversation

Schamper
Copy link
Member

In collaboration with @joost-j <3

This PR adds initial support for Veeam Backup files. Only full, unencrypted backup files are supported at the moment. Support for incremental and encrypted backups will be added at a later date (this was enough work as it is!).

This took some long reverse engineering, so some things may not be 100% correct. The format supports some other features as well (other compression types, external files, some special block types) but we're not yet sure how to generate files that contain those, so those features are also not yet supported.

This also extends the vma-extract utility to allow extraction of both VMA and VBK files.

The performance is untested but it seems quick enough for normal usage. Performance suggestions are welcome by the reviewer.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 75.61375% with 149 lines in your changes missing coverage. Please review.

Project coverage is 68.32%. Comparing base (98a9a66) to head (97430e3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/hypervisor/tools/backup.py 40.68% 86 Missing ⚠️
dissect/hypervisor/backup/vbk.py 86.27% 63 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   61.62%   68.32%   +6.69%     
==========================================
  Files          27       29       +2     
  Lines        2356     2867     +511     
==========================================
+ Hits         1452     1959     +507     
- Misses        904      908       +4     
Flag Coverage Δ
unittests 68.32% <75.61%> (+6.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@twiggler twiggler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first take on supporting such a rather complex backup format.

dissect/hypervisor/backup/vbk.py Show resolved Hide resolved
dissect/hypervisor/backup/vbk.py Outdated Show resolved Hide resolved
tests/test_vbk.py Show resolved Hide resolved
dissect/hypervisor/backup/vbk.py Show resolved Hide resolved
dissect/hypervisor/backup/vbk.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
dissect/hypervisor/backup/vbk.py Show resolved Hide resolved
dissect/hypervisor/backup/vbk.py Outdated Show resolved Hide resolved
dissect/hypervisor/backup/vbk.py Outdated Show resolved Hide resolved
dissect/hypervisor/backup/vbk.py Show resolved Hide resolved
@Schamper Schamper requested a review from twiggler November 2, 2024 21:12
twiggler
twiggler previously approved these changes Nov 5, 2024
Copy link
Contributor

@twiggler twiggler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against backup of windows VM.
Same results as official extract tool

  • One nicpick (rename tmp variable)
  • There are linting issues

tests/test_vbk.py Outdated Show resolved Hide resolved
dissect/hypervisor/backup/vbk.py Outdated Show resolved Hide resolved
@Schamper
Copy link
Member Author

Schamper commented Nov 5, 2024

Will fix those last things and as discussed make a new PR on dissect.archive with the same code.

@twiggler
Copy link
Contributor

twiggler commented Nov 19, 2024

Closed, merged into fox-it/dissect.archive#8

@twiggler twiggler closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants