-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Veeam Backup files (VBK) #31
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 61.62% 68.32% +6.69%
==========================================
Files 27 29 +2
Lines 2356 2867 +511
==========================================
+ Hits 1452 1959 +507
- Misses 904 908 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first take on supporting such a rather complex backup format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against backup of windows VM.
Same results as official extract tool
- One nicpick (rename
tmp
variable) - There are linting issues
Will fix those last things and as discussed make a new PR on dissect.archive with the same code. |
Co-authored-by: twiggler <[email protected]>
Closed, merged into fox-it/dissect.archive#8 |
In collaboration with @joost-j <3
This PR adds initial support for Veeam Backup files. Only full, unencrypted backup files are supported at the moment. Support for incremental and encrypted backups will be added at a later date (this was enough work as it is!).
This took some long reverse engineering, so some things may not be 100% correct. The format supports some other features as well (other compression types, external files, some special block types) but we're not yet sure how to generate files that contain those, so those features are also not yet supported.
This also extends the
vma-extract
utility to allow extraction of both VMA and VBK files.The performance is untested but it seems quick enough for normal usage. Performance suggestions are welcome by the reviewer.