Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make acquire more robust against missing collection profiles #201

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Nov 4, 2024

No description provided.

@pyrco pyrco requested a review from Miauwkeru November 4, 2024 10:27
@pyrco pyrco linked an issue Nov 4, 2024 that may be closed by this pull request
acquire/acquire.py Outdated Show resolved Hide resolved
@pyrco pyrco force-pushed the more-robust-against-missing-profiles branch from a213d3d to 1266399 Compare November 4, 2024 12:21
@pyrco pyrco requested a review from Miauwkeru November 4, 2024 12:22
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 47.18%. Comparing base (910e364) to head (1266399).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
acquire/acquire.py 7.69% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   47.15%   47.18%   +0.02%     
==========================================
  Files          26       26              
  Lines        3425     3423       -2     
==========================================
  Hits         1615     1615              
+ Misses       1810     1808       -2     
Flag Coverage Δ
unittests 47.18% <7.69%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco pyrco merged commit 80f60e2 into main Nov 4, 2024
15 of 20 checks passed
@pyrco pyrco deleted the more-robust-against-missing-profiles branch November 4, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acquire fails when collecting from a "default"-type OS
2 participants