-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make acquire compression configurable #185
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
+ Coverage 43.37% 44.60% +1.23%
==========================================
Files 26 26
Lines 3375 3394 +19
==========================================
+ Hits 1464 1514 +50
+ Misses 1911 1880 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the testcases now fail
Make
tar
andzip
compression output configurable by supplying a--compress-method
argument as mentioned in #182Additionally, some tests have been adjusted to account for this change.