Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start on party sheet v2 #17702

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CarlosFdez
Copy link
Collaborator

@CarlosFdez CarlosFdez commented Dec 13, 2024

This is in development and does not have the final refactor pass. It is here as a show and tell of context and tab management. You can see a use of it in overview-tab.svelte.

V12 doesn't have overridable themes, so this has to be viewed with the light theme or it'll be even more horrendous.

I am currently playing with the current ideas in my head. If there is approval I'll do them, but at this point I'm trying to find out if they're bad ideas:

  1. Implementing a _prepareState() method that _prepareContext() calls. This is a similar paradigm to handlebars part contexts, kinda.
  2. Having BaseSvelteState instead be a separate $appState store that is separate.

I also need to fix window repositioning on re-render. We need to find a way to await until svelte is done re-rendering in _replaceHTML(). It may be doable with the tick() function.

The goal is to avoid deep nesting of "global" props such as user, foundry app, tab groups, and editable. It should not ever be used for regular props that are specific to a sheet, which is why I am considering the split.

@CarlosFdez CarlosFdez force-pushed the party-sheet-v2 branch 6 times, most recently from 6cf90db to 95d3abd Compare January 20, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant