Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented serializable representations of Cairo-specific primitive types #2545

Closed
wants to merge 1 commit into from
Closed

Implemented serializable representations of Cairo-specific primitive types #2545

wants to merge 1 commit into from

Conversation

integraledelebesgue
Copy link
Member

@integraledelebesgue integraledelebesgue commented Oct 1, 2024 •
edited
Loading

This was referenced Oct 1, 2024
Closed
Closed
Closed
cptartur
cptartur requested changes Oct 2, 2024
View reviewed changes
crates/conversions/src/u256.rs Outdated Show resolved Hide resolved
crates/conversions/src/u512.rs Outdated Show resolved Hide resolved
@integraledelebesgue integraledelebesgue force-pushed the spr/master/fad6001c branch 4 times, most recently from 67f3995 to 8012988 Compare October 3, 2024 13:36
@integraledelebesgue integraledelebesgue mentioned this pull request Oct 4, 2024
Merged
@integraledelebesgue integraledelebesgue force-pushed the spr/master/fad6001c branch 3 times, most recently from e485614 to 31ecdab Compare October 4, 2024 19:16
cptartur
cptartur approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a bunch of comments about adding unittests, please aggregate them accordingly.

Otherwise approved.

crates/conversions/src/biguint.rs Outdated Show resolved Hide resolved
crates/conversions/src/bytes31.rs Outdated Show resolved Hide resolved
crates/conversions/src/biguint.rs Outdated Show resolved Hide resolved
crates/conversions/src/bytes31.rs Outdated Show resolved Hide resolved
crates/conversions/src/u256.rs Outdated Show resolved Hide resolved
crates/conversions/src/u256.rs Outdated Show resolved Hide resolved
crates/conversions/src/u384.rs Outdated Show resolved Hide resolved
crates/conversions/src/u512.rs Outdated Show resolved Hide resolved
crates/conversions/src/u96.rs Outdated Show resolved Hide resolved
@integraledelebesgue integraledelebesgue force-pushed the spr/master/fad6001c branch 2 times, most recently from ddd1977 to 1840e74 Compare October 11, 2024 11:26
@integraledelebesgue integraledelebesgue changed the title Implemented representations of Cairo u256 and u512 Implemented serializable representations of Cairo-specific primitive types Oct 11, 2024
@integraledelebesgue
Copy link
Member Author

I added some issues:

  • #2575 for unit tests
  • #2576 for CairoU256::from_bytes

@integraledelebesgue integraledelebesgue force-pushed the spr/master/fad6001c branch 3 times, most recently from 6327ef2 to a84a118 Compare October 14, 2024 07:30
@integraledelebesgue
Copy link
Member Author

✓ Commit merged in pull request #2555

github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2024
@integraledelebesgue
Introduced Data Transformer (#2555)
a2e3c7d 
**Stack**:
- #2555
- #2548
- #2547
- #2546
- #2545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@ksew1 ksew1 Awaiting requested review from ksew1

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@integraledelebesgue @cptartur