Handle parsing and serialization of etherscan api version #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
Author
|
the |
mattsse
requested changes
May 1, 2025
| pub enum EtherscanApiVersion { | ||
| #[default] | ||
| V1, | ||
| #[default] |
Contributor
Author
There was a problem hiding this comment.
Another option would be to not specify a default here and specify a default on the forge library.
Comment on lines
-117
to
-118
| /// Create a new client with the correct endpoint with the chain and chosen API v2 version | ||
| pub fn new_v2_from_env(chain: Chain) -> Result<Self> { |
Member
There was a problem hiding this comment.
can we keep this so that this doesn't break?
Contributor
Author
There was a problem hiding this comment.
Sure — it only makes sense imo if the default is V1 and maybe it should still be. Not sure about other tools using this package.
| .with_api_key(api_key) | ||
| .chain(chain)? | ||
| .build() | ||
| pub fn new_with_api_version( |
mattsse
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add Etherscan API Version types for reasonable parsing and serialization into the toml configuration files, these functions were added to block_explorers.
See: foundry-rs/foundry#10298