-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated project structure and added basic test cases to project #13
Conversation
c9e5795
to
fc71c22
Compare
67389b1
to
bec1cda
Compare
There can be some more changes in the project structure, let's go over it in our next call. |
1cb00d7
to
2929585
Compare
updated project structure to avoid import cycle added a different package for database where: there is function related to migration of database and populating database added basic test cases: added API test cases for create, update, get license by shortname and search in licenses added user test cases for create and get user by id updated meta to pagination meta for better discription Signed-off-by: Kavya Shukla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the test command to the Github Actions as well.
r.POST("/api/search", SearchInLicense) | ||
r.GET("/api/licenses", FilterLicense) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create an issue to merge these two endpoints into a single one.
@@ -56,7 +56,7 @@ type LicenseJson struct { | |||
// license retrieval operation. | |||
// It contains information that provides context and supplementary details | |||
// about the retrieved license data. | |||
type Meta struct { | |||
type PaginationMeta struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create an issue to make this struct as free form key-value mapping field
Co-authored-by: Avinal Kumar <[email protected]> Signed-off-by: Gaurav Mishra <[email protected]>
feat: updated the project structure and added test case
updated project structure to avoid import cycle
added basic test cases:
updated meta to pagination meta for better discription