-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request Template Updated #502
base: master
Are you sure you want to change the base?
Conversation
@@ -4,6 +4,7 @@ | |||
<!-- Add the issue number that is fixed by this PR (In the form Fixes #123) --> | |||
|
|||
Fixes # | |||
[Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed as already at line 4 description about it is given. You can edit that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both lines have different meanings, please see carefully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I am saying that please edit at line 4 to merge both information. As both are related to issue number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neeraj3029 Squash Your Commits/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash your commits
@samagragupta Please review |
LGTM |
Fixes #498
Checklist
master
branch.Short description of what this resolves:
Pull Request now asks for Screenshots and is more descriptive now.
Changes proposed in this pull request:
Pull Request now asks for Screenshots and is more descriptive now.