Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create event model and its children #9123

Open
wants to merge 2 commits into
base: dev-v3
Choose a base branch
from

Conversation

poju3185
Copy link

Fixes #9104

Short description of what this resolves:

Add the following models:

  • discount_code_tickets
  • discount_codes
  • event_sub_types
  • event_types
  • events
  • groups
  • tickets

I add these models by following the schema here.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@poju3185
Copy link
Author

poju3185 commented Mar 12, 2024

This also fixes #9106

@Shivangi-ch
Copy link

I think instead of creating a separate app for each model, a better way would be to group functionally related models in the same app.
For example, models for event_sub_types, event_types, events, etc can be put in the same app instead of separate apps.
Having a separate app for each model would make the code structure messy and difficult to maintain.

One other way would be to make a models module and add all the models inside it.

@hongquan @marcoag what do you think which structure will work better for us?

@poju3185
Copy link
Author

Hi @Shivangi-ch, thanks for your reply. I use different apps because I saw the old models are all in seperate apps. If everyone agree that we should put some of them in the same app, I am willing to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants