Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature-8787: Change the "age" field of the custom form #8901

Merged
merged 2 commits into from
Jun 22, 2023
Merged

feature-8787: Change the "age" field of the custom form #8901

merged 2 commits into from
Jun 22, 2023

Conversation

khangon
Copy link
Contributor

@khangon khangon commented Jun 20, 2023

Fixes #8787

Short description of what this resolves:

  • Change the "age" field of the custom form

Changes proposed in this pull request:

  • change validation for age group in request

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the feature label Jun 20, 2023
@khangon
feature-8787
e54de3d 
add one more option for age
@khangon khangon marked this pull request as ready for review June 21, 2023 02:34
@ghost ghost assigned norbusan and cweitat Jun 22, 2023
@mariobehling mariobehling merged commit 223f5d0 into fossasia:development Jun 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

@norbusan norbusan norbusan approved these changes

Assignees

@norbusan norbusan

@cweitat cweitat

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@khangon @mariobehling @norbusan @cweitat @odkhang