Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-7984: Show test/live key of Stripe under Payments section #8888

Merged
merged 4 commits into from Jun 18, 2023
Merged

fix-7984: Show test/live key of Stripe under Payments section #8888

merged 4 commits into from Jun 18, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2023

Fixes #7984

Short description of what this resolves:

Show test/live key of Stripe under Payments section

Changes proposed in this pull request:

  • Create new record "stripe_mode" on table Setting
  • Response new column "stripe_mode" when user Get or Update Setting

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@norbusan
Copy link
Member

@lthanhhieu

thanks for the PR, a few comments:

Fixes #7984

This is not the correct issue, please link the correct issue.

Also, please fix the Codacy Static Code Analysis, look into the details, it is simple, there is one unused import.

Thanks

@cweitat cweitat merged commit e7e537c into fossasia:development Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants