chore: Add instructions to publish it to GitHub Pages #1161
Conversation
|
Deployment link -> https://mayank8318.github.io/open-event-frontend/ |
Codecov Report
@@ Coverage Diff @@
## development #1161 +/- ##
============================================
Coverage 31.43% 31.43%
============================================
Files 305 305
Lines 2373 2373
============================================
Hits 746 746
Misses 1627 1627Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Let's follow the instructions of the project readme from https://github.com/poetic/ember-cli-github-pages. It should be the most updated one.
| `git checkout -b publish_gh_pages` | ||
|
|
||
| * Install <strong>ember-cli-github-pages</strong> addon. <br> | ||
| `ember install:addon ember-cli-github-pages` |
There was a problem hiding this comment.
I am not sure we can install addon like this. I mean it gave me an error couple of days ago when I tried. I would suggest replacing it with ember install ember-cli-github-pages
There was a problem hiding this comment.
Yes. install:addon is from ember 1.x era
There was a problem hiding this comment.
@mayank8318 please update the doc to match with https://github.com/poetic/ember-cli-github-pages
|
@srv-twry @niranjan94 Updated :) |
| ember install ember-cli-github-pages | ||
| ``` | ||
|
|
||
| * Open <strong>environment.js</strong> file from the project directory and change the value of `rootURL` from `/` to `open-event-frontend` |
There was a problem hiding this comment.
environment.js file is in the config directory. It would be great to mention it.
docs/installation/local.md
Outdated
| * `cp .env.example .env` | ||
|
|
||
| ### Note: | ||
| If you face error in `npm install` for node and npm version, then install node version: v7.10.1 (npm version: 5.3.0 gets installed with it), which satisfies check-node-version and project runs perfectly on this configuration. |
There was a problem hiding this comment.
This can be removed. As we no longer recommend npm. This project comes bundled only with a yarn-compatible lockfile.
Checklist
developmentbranch.Short description of what this resolves:
Adds instructions to publish the project to github pages.
Fixes #1150