add-video-link #140
Open
add-video-link #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request adds a new feature to include an online video URL in the event settings. The changes involve adding a new field to the event form, updating the event settings template to include this new field, and modifying the event header template to display the video link if it is set. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @AviGawande - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add tests for the new video_link feature to ensure its functionality and prevent regressions.
- Consider adding a comment in the code explaining that additional URL validation is not necessary due to Django's URLField providing basic validation.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
Please add screenshots. |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/references issue #133 . It does so by providing an URL in the events general settings
How has this been tested?
Checklist
Summary by Sourcery
This pull request introduces a new feature allowing users to add an online video URL to the event settings. The event header will display a 'Videos' button linking to this URL if provided. Tests have been added to ensure the new functionality works as expected.