Skip to content

Conversation

@ShashwatXD
Copy link

@ShashwatXD ShashwatXD commented Dec 26, 2025

PR Description

This pull request fixes an issue where query parameters present in a cURL URL were detected during import but were not added to the request’s Params tab.

Related Issues

Closes #978

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with the project main branch before making this PR
  • I am using the latest Flutter stable branch (flutter upgrade)
  • I have run the tests (flutter test) and all tests are passing

Added / Updated Tests

  • Yes
  • No, this change completes missing parameter-mapping logic during cURL import and does not modify existing business rules or data models.

OS Tested On

  • macOS
  • Windows
  • Linux

@Aman071106
Copy link
Contributor

Aman071106 commented Dec 28, 2025

@ShashwatXD great work on addressing this issue - the fix looks ok.

One small suggestion for the PR description:
The checklist items aren’t rendering properly because of extra spaces inside the brackets.
For example, [ x] or [x ] doesn’t register as a valid Markdown checkbox.

Using [x] (with no leading/trailing spaces) inside the Markdown field will format the checklist correctly and improve the readability of the PR, which helps maintainers during review.

Other than that, thanks for contributing - appreciate your work on this!

@ShashwatXD
Copy link
Author

@Aman071106 thanks for the suggestion, i have updated the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query parameters from cURL imports are not added to request

2 participants