-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Implement PutClass and DeleteClass for WMI #1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@anadrianmanrique Some updates on this PR. Please check <3 |
|
Wow, this is awesome!!!! |
|
@anadrianmanrique When you get a chance, please review this PR — I’m pretty excited about these changes, they should make a real difference on WMI! 💪 |
|
@NtAlexio2 thanks, yes, this PR has been already prioritized to be reviewed/tested in the context of 0.14-dev |
|
@NtAlexio2 BTW, could you add the test case in https://github.com/fortra/impacket/blob/master/tests/SMB_RPC/test_wmi.py ? |
|
Hi @NtAlexio2, as @XiaoliChan pointed out, would it be possible to add tests cases coverage? |
|
sure, I'll fix that asap |
|
@anadrianmanrique done |
|
@NtAlexio2 Man, this is awesome, will improve my |
|
I added a couple of cases in order to improve coverage of the changes. Thanks |
This PR adds two most wanted
PutClassandDeleteClassfunctions towmi.py(issue #1186, this Reddit link, wmiexec-Pro project, ...) which unlocks many new features for wmi in future. The PR also includes:ObjectFlagsconstants referenced in MS-WMIO (2.2.6 ObjectFlags) towmi.pyfile. It helps to easy debugging and code maintenance.CLASS_AND_METHODS_PARTclass to handle empty class names.