Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new optional dependencies for Apple Silicon lint, build, and test support #176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

juliaschiller150
Copy link

@juliaschiller150 juliaschiller150 commented Jan 10, 2025

Description

Previously, @rollup/rollup-linux-x64-gnu was listed as the only optional npm dependency. This allows the project to run tests and build on Linux machines, but the project lacked the necessary rollup dependency to build or test on Apple Silicon.

This MR rectifies the issue by adding @rollup/rollup-darwin-arm64 as a new optional dependency. npm should automatically detect one's local machine architecture and install the relevant rollup dependency accordingly.

This opens the door to new contributions by other engineers running Apple machines!

EDIT: I've also added @biomejs/cli-darwin-arm64 as another optional dependency to ensure linting runs on Apple Silicon too.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I installed a fresh copy of this branch in a brand new directory and ran npm ci. The correct rollup dependency was automatically installed, and I was able to test and build the project locally. I suggest trying this same scenario on a Linux machine to validate further.

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings or errors
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

pkg-pr-new bot commented Jan 10, 2025

Open in Stackblitz

npm i https://pkg.pr.new/forge42dev/react-router-devtools@176

commit: 092543c

@AlemTuzlak
Copy link
Contributor

@juliaschiller150 would you mind running npm run check:fix so that linting gets sorted, thank you for the contribution!

@juliaschiller150 juliaschiller150 changed the title Introduce new optional dependency for Apple Silicon build and test support Introduce new optional dependency for Apple Silicon lint, build, and test support Jan 10, 2025
@juliaschiller150 juliaschiller150 changed the title Introduce new optional dependency for Apple Silicon lint, build, and test support Introduce new optional dependencies for Apple Silicon lint, build, and test support Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants