add currency symbols & improve amount fields in various views #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- show currency symbol - support decimal comma - show warning color when more than two decimals entered
- show currency symbol - show warning when more than two decimals entered (decimal comma was already supported)
missing: currency symbol on disabled price field when editing stock article
|
I'd like some feedback on this (and #840 ) before I move on to the next fixes/features ;) |
|
sorry for the late reply, unfortunately this is not an easy change. You changed the type of the input fields to The main issue happens when the view prints numbers in german locale (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currency symbols added to various forms and other views.
The new_collection form now also supports decimal commas, fixing #722 (at least the initial issue)