Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group orders: display deposit, tolerance only if necessary #1076

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

mjavurek
Copy link
Contributor

@mjavurek mjavurek commented Dec 5, 2024

In the current foodsoft version, it is not visible for ordergroups during ordering, if articles contain a deposit and ordergroups may think the article is more expensive. Tolerances are currently shown for all articles, even for articles without tolerance, which makes the view unnecessarily complex. This PR resolves both issues:

Tolerances and deposit are not shown if there is none of them:
grafik

An additional column is displayed for the deposit if there is at least one article in the order with deposit. This is important for the ordergroups so that they know that the price shown includes a deposit.
grafik

If there is at least one article with tolerance (unit quantity > 1), additional columns appear with tolerance information only at corresponding articles.
grafik

@mjavurek
Copy link
Contributor Author

mjavurek commented Dec 6, 2024

Todos:

  • add .contains_deposit in language files

@mjavurek
Copy link
Contributor Author

mjavurek commented Dec 17, 2024

Actually, the markup is also calculated for the deposit included in the gross price:

((price + deposit) * (1+tax)) * markup

At least there should be an option to exclude the deposit from the markup, like FoodsoftConfig[:deposit_with_markup]:

(price * (1+tax)) * markup + (deposit * (1+tax))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant