-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack trace URL improvements #3038
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: Adrian Hill <[email protected]>
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="stack-frame-url-imrpvoements")
julia> using Pluto |
The new URL code does not work on Julia 1.6, and I don't see an easy way to make it work :( |
It might be worth trying this code JuliaLang/julia#47709 (comment) ? RegistryInstances might be okay to add as a dep |
The clickable URL feature is what I'm talking about in #2737 (comment). I would selfishly prefer JULIA_EDITOR over an URL because
I know you favor simplicity and what's-best-for-students, so I'm not going to get my hopes up. This PR as is looks great! |
I think launching an editor doesnt fit our target audience |
Yes, that's what I thought you would say 🙂. Oh well! I agree that for students the URL works out better. You could in theory favor JULIA_EDITOR if it's defined (since it's undefined by default) and fallback to the URL, but it's ugly logic and complexity. |
New features:
Example
Example