Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid adding packages that exist in the sysimage #2832

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pankgeorg
Copy link
Collaborator

Experimental. When someone is using a sysimage, using SysImageModule triggers a Pkg.add. This avoids that. I'm still testing if this is exactly what I have in mind; we probably need to do a special treatment that is similar to stdlibs too.

Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="pg/pkg-sysimage-handling")
julia> using Pluto

@fonsp
Copy link
Owner

fonsp commented Mar 7, 2024

Don't you want to disable the package manager? Like this but not just for new notebooks? #1631

@pankgeorg
Copy link
Collaborator Author

Don't you want to disable the package manager? Like this but not just for new notebooks? #1631

I think I don't, no. The Package Manager is amazing. There used to be some limitations (which I don't completely understand) that disallowed us from adding new packages and/or doing a correct resolve in the context of a sysimage. But that doesn't seem to be the case any more (1.10.2). We just need to stop the Package Manager from going crazy with packages in the sysimage, and let it do what it does best for the rest. I think this PR does that, but I haven't tested out thoroughly yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants