fix: make sure mathjax will be bundled #2821
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="pg/offline-mathjax")
julia> using Pluto |
|
The tex file appears in the bundle twice :o https://github.com/fonsp/Pluto.jl/actions/runs/7972036214/job/21762929218?pr=2821#step:8:181 |
|
It seems like MathJax v4 is almost released! And there are already beta releases. It might make sense to make the switch to v4 first before, otherwise we spend quite some effort debugging this, while the v4 will be bundled and included very differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
not-the-src-yetattribute was, of course, not being bundled. we use thenew URL()trick of parcel to make sure this will load, keeping the same flow.