Fix a back-link bug #106
Open
Fix a back-link bug #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug, which creates the empty-back-link when the page.back_page property is not declared, has been found. It seems like the 'find' filter of the liquid does not work properly. Now, back-link.html uses both 'where' and 'first' filters to create the proper back link, only when the page.back_page is declared in the current page.
|
I think the issue is, that the find filter requires Jekyll 4.1.0, but GitHub Pages currently only supports 3.9.2, so the back arrow is always shown, but has no href or label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug, which creates the empty-back-link when the page.back_page property is not declared, has been found.
It seems like the 'find' filter of the liquid does not work properly.
Now, back-link.html uses both 'where' and 'first' filters to create the proper back link, only when the the page.back_page is declared in the current page.