-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance via Triemap in workspace #1406
Improve performance via Triemap in workspace #1406
Conversation
I am not sure why this test case is suddenly failing. I have to look at this with some fresh brains later this week. Always open for suggestions. |
@riccardoferretti On my local machine I have a passing test, but in CI I can't make it work. Could you have a look in your environment and see what happens? Perhaps you can spot a problem, I am missing it right now. |
(from Discord) yeah I saw that. Weird thing was that I was able to reproduce it locally, then made a small change to the content of the definition of |
Odd, but do you wanna try the same thing and see if it passes CI? |
Well... adding the text didn't help, unfortunately. But, it did help me to think about the problem differently. What I found is that the references are returned in no particular order. Depending on the random file name, the first wikilink might come in as first reference or as second. If the latter happens, that will fail the test. The random file names explain the flakiness of the test. I expect this is an issue since this change. As TrieMap does not hold the insertion order, the issue manifests during the build. For other places I expect this not to be a problem as they are sorted in their view/UI panel. Other than that, this PR is ready for review and testing. Just did a test with the 10000s folder, the activation log states:
Compared to 25+ seconds that the current release needs for loading that workspace. |
Ahh makes perfect sense, good find! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks @pderaaij !
The compromised version of #1391.