Allow clients to specify content type #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the signer always overrides the content type of the request to be `application/json`. There's no need for this, and it means that there's no way to override the header when necessary. This change checks to see if the content type header is set, and if the header is set then it's left as-is.
ahjones
added a commit
to ahjones/cli
that referenced
this pull request
Jun 28, 2023
Change the default content type to `application/json`. It was always ignored anyway, but I've made another PR in fn_go that means that it will be used: fnproject/fn_go#56 Once that PR is merged we should revendor `fn_go` with this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the signer always overrides the content type of the request to be
application/json. There's no need for this, and it means that there's no way to override the header when necessary.This change checks to see if the content type header is set, and if the header is set then it's left as-is.