Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rails 4.3 → Rails 6, Ruby 2.5 → 3.2.3 Upgrade #50

Closed
wants to merge 2 commits into from

Conversation

kigster
Copy link
Collaborator

@kigster kigster commented Feb 14, 2024

This is a work in progress.

I got it to a point where the Rails 6.0 boots the console, and you can run rake tasks, migrations, and specs.

However, specs are not yet all passing.

There is still plenty to do, but it's getting there.

@kigster kigster self-assigned this Feb 14, 2024
@kigster kigster requested a review from a team as a code owner February 14, 2024 19:16
Copy link
Contributor

@mike-matera mike-matera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not possible to review this PR because there are too many changes. I'm happy to help if I can but I see these issues as blocking useful review:

  1. Virtually every Ruby file has changed and the changes seem to have been made by robot. These bury consequential changes in an ocean of unimportant ones.
  2. There is a large volume of vim files here. It's generally preferred to let developers keep their environments for themselves and not push settings into a source code repo.

@kigster ... If you're taking over the maintenance of this repo, that's great and I want to support you. We don't really need the PR process for development that has a single programmer. So I'm fine if you want to merge this and move forward.

@kigster
Copy link
Collaborator Author

kigster commented Feb 15, 2024

@mike-matera this PR is not ready for a review to begin with.

Secondly, having spoken to several people who upgrade rails for a living, there is no easy incremental way of doing it for our app unfortunately.

Luckily we have a great test coverage here and I plan to increase it before making this ready for a review, as well as placing this branch on a review app.

While I appreciate your concern, let's cross that bridge when it's ready.

@kigster
Copy link
Collaborator Author

kigster commented Feb 15, 2024

I added @fnf-org/fnf-engineeres to the reviewer list to make interested folks aware this work is happening to avoid any effort duplication. I've coordinated it with @beingmattlevy.

The description clearly says it's not yet ready. Sorry if this caused any confusion.

@kigster
Copy link
Collaborator Author

kigster commented Feb 15, 2024

The point about vim folder is valid. I was also thinking it does not belong here.

@kigster kigster marked this pull request as draft March 11, 2024 18:08
@kigster kigster changed the title WIP: Rails 4.2 -> 6.0 + Ruby 2.5 -> 3.1.1 Upgrade WIP: Rails 4.3 → Rails 6, Ruby 2.5 → 3.2.3 Upgrade Mar 11, 2024
@kigster kigster added split-PR-into-smaller-chunks This issue or PR should be broken up into several smaller throw-away-ignore Ignore this PR and removed work-in-progress dependency-upgrades Dependency upgrade split-PR-into-smaller-chunks This issue or PR should be broken up into several smaller labels Mar 11, 2024
@kigster kigster closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
throw-away-ignore Ignore this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants