Skip to content

Conversation

uuiid
Copy link
Contributor

@uuiid uuiid commented Aug 22, 2025

fix #1446

@fnc12 fnc12 requested review from trueqbit and fnc12 August 22, 2025 05:19
@fnc12
Copy link
Owner

fnc12 commented Aug 22, 2025

hi @uuiid . Thanks for this PR. Please fix failing CI https://ci.appveyor.com/project/fnc12/sqlite-orm/builds/52612615 and please replace non-English commit messages to English cause this project is being ran in English as open source project.

@uuiid
Copy link
Contributor Author

uuiid commented Aug 22, 2025

Copy link
Collaborator

@trueqbit trueqbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @uuiid for your valuable contribution!

Since it's not a problem of the result_set_iterator it's better to solve it at the level of the column_result_proxy facility.

template<class Tpl>
struct column_result_proxy<Tpl, match_specialization_of<Tpl, std::tuple>>
    : tuple_transformer<Tpl, column_result_proxy_t> {};

Additionally there are already static unit tests for result set iteration in tests/static_tests/iterator_t.cpp, which can be amended.

For reference see a comparison of a commit in branch that I created.

But I think it would be fair to credit you with the contribution.

@uuiid
Copy link
Contributor Author

uuiid commented Aug 25, 2025

Great, much better than my solution, please merge the https://github.com/fnc12/sqlite_orm/tree/fix_multi_colresult branch directly, and close this pull request directly

@trueqbit
Copy link
Collaborator

Closed in favor of #1448

@trueqbit trueqbit closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants