-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add friendly name execution object column #5965
base: master
Are you sure you want to change the base?
add friendly name execution object column #5965
Conversation
Signed-off-by: wayner0628 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5965 +/- ##
==========================================
+ Coverage 36.85% 36.95% +0.10%
==========================================
Files 1310 1311 +1
Lines 131227 131409 +182
==========================================
+ Hits 48362 48562 +200
+ Misses 78668 78632 -36
- Partials 4197 4215 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to update the migration since we add a new column.
https://github.com/flyteorg/flyte/blob/master/flyteadmin/pkg/repositories/config/migrations.go#L1278
Signed-off-by: wayner0628 <[email protected]>
Tracking issue
#5964
Why are the changes needed?
We want to improve execution name readability, while avoid a high possibility of collision using friendly names, so we make it a execution object
See the discussion: #5740
What changes were proposed in this pull request?
Execution objects now include a friendly name column.
How was this patch tested?
This PR focuses on updates to the execution model column only, as there are no modifications to
Flyteconsole
. The changes won't reflect on ui appearance.Setup process
Screenshots
Check all the applicable boxes
Related PRs
#5637
#5740
Docs link