WIP: Prebuild Stage Feature #430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r discussion If the feature is seen as plausible, I will commit further changes (tests, etc) which comply with the contributions guidelines Signed-off-by: Oliver Bähler <[email protected]>
oliverbaehler
changed the title
|
I have tested your PR (#430) with my own stuff and it's working pretty well. I hope it will be merged soon. |
|
@stefanprodan What is your opinion about the clarified scope of the |
This was referenced Nov 18, 2021
|
I guess this won't be implemented |
|
Just going through this, any reason why this wasn't picked? It will simplify a lot of kustomization files with paths made dynamic. |
|
Are there any plans to include this? Thanks! |
|
+1 I would love this as well. It would greatly simplify my repository layout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried implementing a solution for issue #414
Since this is my first contribution in go i am not quiet sure how good it is. But i tested it and it works. But hard to tell.
I created this PR as Draft, so we can discuss over the feature.
If the feature is seen as plausible, I will commit further changes (tests, etc) which comply with the contributions guidelines.
I didn't make them yet, because I don't want to waste time for something that could be rejected.
Signed-off-by: Oliver Bähler [email protected]