Add disableTakeOwnership to Helm install/upgrade actions
#1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar-mallikarjuna
force-pushed
the
fix-1139
branch
from
5dc3682 to
d684a7d
Compare
This change adds a new field called `disableTakeOwnership` to `.spec.install` and `.spec.upgrade`. The flag allows users to disable ignoring helm annotations and labels before taking ownership of existing resources during install and upgrade. Signed-off-by: Kumar Mallikarjuna <[email protected]>
kumar-mallikarjuna
force-pushed
the
fix-1139
branch
from
d684a7d to
98622cd
Compare
matheuscscp
reviewed
Jan 9, 2025
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
@matheuscscp , added a couple of tiny tests. Please LMK if these work. |
|
Thanks @kumar-mallikarjuna, I'll take a look tomorrow |
Signed-off-by: Kumar Mallikarjuna <[email protected]>
matheuscscp
reviewed
Jan 10, 2025
Signed-off-by: Kumar Mallikarjuna <[email protected]>
matheuscscp
reviewed
Jan 10, 2025
Signed-off-by: Kumar Mallikarjuna <[email protected]>
matheuscscp
approved these changes
Jan 10, 2025
stefanprodan
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new field called
disableTakeOwnershipto.spec.installand.spec.upgrade. The flag allows users to disable ignoring helm annotations and labels before taking ownership of existing resources during install and upgrade.Closes #1139
xref: helm/helm#13439