-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce visibility flag for bootstrap gitlab #4866
Introduce visibility flag for bootstrap gitlab #4866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nagyv please upload your signing key to GitHub and also signoff your commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation looks good to me.
Left a few more minor comments and a question before we consider this ready.
Also, @nagyv some commits are missing git signoff due to which the CI checks are failing. I think you can squash the commits as appropriate and signoff only the relevant commits.
@darkowlzz in this case, it seems we are done. Are you ok approving?
…-------- Eredeti üzenet --------
2024. 07. 15. 15:16-kor, Sunny ezt írta:
@darkowlzz commented on this pull request.
---------------------------------------------------------------
In [cmd/flux/bootstrap_gitlab.go](#4866 (comment)):
> @@ -133,6 +143,11 @@ func bootstrapGitLabCmdRun(cmd *cobra.Command, args []string) error {
return fmt.Errorf("--token-auth and --deploy-token-auth cannot be set both.")
}
+ if !gitlabArgs.private {
okay, sounds good.
—
Reply to this email directly, [view it on GitHub](#4866 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAA65TZTAHYREIV634HAC7TZMPDSRAVCNFSM6AAAAABKCLLSMGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZXGY4DQNZUHA).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks.
@nagyv I have approved it. This branch is out-of-date with the base branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darkowlzz @stefanprodan Squashed and rebased. 🚀 |
You need to rebase with upstream, your fork is behind |
Signed-off-by: Viktor Nagy <[email protected]>
@stefanprodan Are we good now? |
This MR introduces a
––visibility=private|public|internal
flag forbootstrap gitlab
.At the same time it deprecates the
--private
flag.Related to #3817