Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing of metrics server secret to flagger #1672

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joedborg
Copy link

An attempt at fixing #1671. I'm not much of a Go wizard, so it probably requires some cleanup.

This adds the ability to add --metrics-server-secret-ref to give the ability to auth against external Prometheus endpoints.

Signed-off-by: Joe Borg <[email protected]>
@joedborg
Copy link
Author

@stefanprodan and chance I can get a review on this please?

@aryan9600
Copy link
Member

is it not possible to define custom MetricTemplate objects pointing to the prom server with the appropriate credentials? the query can be copy pasted from flagger's codebase. that's hardcoded anyway: https://github.com/fluxcd/flagger/blob/main/pkg/metrics/observers/istio.go#L27

@joedborg
Copy link
Author

@aryan9600 that's what I'm doing as a work around but I'd like the built ins to work as described without having to duplicate code from the repo to get it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants