delete_bank(): update job usage after bank is removed with --force#808
Merged
mergify[bot] merged 2 commits intoflux-framework:masterfrom Jan 26, 2026
Merged
delete_bank(): update job usage after bank is removed with --force#808mergify[bot] merged 2 commits intoflux-framework:masterfrom
delete_bank(): update job usage after bank is removed with --force#808mergify[bot] merged 2 commits intoflux-framework:masterfrom
Conversation
Problem: The job usage for the rest of the hierarchy is not updated after a bank is deleted with --force, which leads to inconsistencies with how usage is reported throughout the hierarchy, i.e. the parent banks will keep the usage of a bank that is deleted. Update the job usage for the bank hierarchy when a bank is deleted with --force. Fixes flux-framework#802
Problem: There are no tests that check that a database hierarchy's job usage is properly updated after a bank is deleted with --force. Add some tests.
cmoussa1
added
bug-fix
Member
Author
|
Thanks @jameshcorbett! Setting MWP here |
Contributor
Merge Queue Status✅ The pull request has been merged at 33014de This pull request spent 7 seconds in the queue, with no time running CI. Required conditions to merge
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #808 +/- ##
=======================================
Coverage 82.93% 82.93%
=======================================
Files 27 27
Lines 2479 2479
=======================================
Hits 2056 2056
Misses 423 423 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Parent banks inadvertently keep the usage of a bank that is deleted with
--force, which leads to inconsistent reporting.This PR just adds an update for the job usage for the bank hierarchy when a bank is deleted with
--force. A quick test is also added to ensure that parent banks' usage is also updated after a bank is removed with--force.Fixes #802