Skip to content

Conversation

@cmoussa1
Copy link
Member

@cmoussa1 cmoussa1 commented Jul 1, 2025

Problem

checks_run.sh has two instances of creating a coverage.rc file.


This PR removes the duplicate creation of coverage.rc. Also looking to see if this might fix the missing Python bindings coverage for this repository.

@cmoussa1 cmoussa1 added improvement upgrades to an already existing feature testing issues that deal with testing labels Jul 1, 2025
@cmoussa1 cmoussa1 changed the title [WIP] codecov: remove duplicate coverage.rc file creation [WIP] checks-run: remove duplicate coverage.rc file creation Jul 1, 2025
@cmoussa1 cmoussa1 force-pushed the add.python.codecov branch 2 times, most recently from f026d83 to cbd42c9 Compare July 1, 2025 21:13
@grondo
Copy link
Contributor

grondo commented Jul 1, 2025

Did this end up being a problem? I thought checks_run.sh was copied from flux-core and I'm not seeing a duplicate coverage.rc but I'm probably missing something that should be obvious, sorry. In any event, we should try to keep changes synced if you're going to continue to use the script from flux-core, so maybe we need a change there too?

@cmoussa1
Copy link
Member Author

cmoussa1 commented Jul 1, 2025

No, not a problem. I opened this PR mostly as an experiment to see if removing the duplicate coverage.rc that I had in flux-accounting's checks_run.sh (I think due to my my negligence in #644) would actually trigger the Python bindings from actually getting picked up by Codecov, but I'm still not seeing coverage there. 🤷

@grondo
Copy link
Contributor

grondo commented Jul 1, 2025

I wonder if this error is the problem:

  No source for code: '/usr/src/usr/src/src/bindings/python/fluxacct/accounting/__init__.py'.

I'm not sure why the extra /usr/src, but maybe you can see if you add ignore_errors = True to the coverage.rc if you can get past that?

@cmoussa1 cmoussa1 force-pushed the add.python.codecov branch from cbd42c9 to b596c9b Compare July 1, 2025 23:16
@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.11%. Comparing base (ef310b5) to head (b596c9b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #682   +/-   ##
=======================================
  Coverage   84.11%   84.11%           
=======================================
  Files          26       26           
  Lines        2185     2185           
=======================================
  Hits         1838     1838           
  Misses        347      347           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmoussa1 cmoussa1 force-pushed the add.python.codecov branch from b596c9b to a771978 Compare July 2, 2025 17:02
Problem: checks_run.sh has two instances of creating a coverage.rc
file.

Remove the duplicate creation of coverage.rc.
@cmoussa1 cmoussa1 force-pushed the add.python.codecov branch from a771978 to 027fe56 Compare July 2, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement upgrades to an already existing feature testing issues that deal with testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants