plugin: initialize factor weights on plugin load#458
Merged
mergify[bot] merged 1 commit intoflux-framework:masterfrom Jun 7, 2024
Merged
plugin: initialize factor weights on plugin load#458mergify[bot] merged 1 commit intoflux-framework:masterfrom
mergify[bot] merged 1 commit intoflux-framework:masterfrom
Conversation
cmoussa1
added
improvement
grondo
approved these changes
Jun 6, 2024
Contributor
grondo
left a comment
grondo
left a comment
There was a problem hiding this comment.
This is great! Just one very minor comment.
src/plugins/mf_priority.cpp
Outdated
Comment on lines
204
to
205
| if (fshare_weight != -1) priority_weights["fairshare"] = fshare_weight; | ||
| if (queue_weight != -1) priority_weights["queue"] = queue_weight; |
Contributor
There was a problem hiding this comment.
I find single line conditionals a little hard to read, I'd suggest breaking these into two lines for readability.
I see we didn't comment on this earlier so this is just a suggestion not required.
Member
Author
There was a problem hiding this comment.
No problem - I think that's perfectly reasonable. I'll push up a fix to break these up into two lines. 👍
Problem: The weight of each factor is checked every time the priority of a job is calculated. It would be cleaner to put this check somewhere else so it does not need to be repeated. Create defaults for the weights of each factor used in the priority calculation of a job. Initialize each weight when the plugin is loaded. In the callback for conf.update, check to see if these weights have been configured; if not, continue to use the defaults defined at the top of the file.
cmoussa1
force-pushed
the
move.factor.init
branch
from
932c6d1 to
9c2ed1c
Compare
Member
Author
|
Thanks for reviewing @grondo! I'll set MWP here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mentioned as possible cleanup in #455, the weight of each factor is checked every time the priority of a job is calculated. It would be cleaner to put this check somewhere else so it does not need to be repeated for every job.
This PR creates defaults for the weights of each factor used in the priority calculation of a job and initializes each weight when the plugin is first loaded. In the callback for
conf.update, it then checks to see if these weights have been configured; if not, it will just continue to use the defaults defined at the top of the file.