Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements about recent issues #1186

Merged
merged 19 commits into from
Sep 22, 2024
Merged

Improvements about recent issues #1186

merged 19 commits into from
Sep 22, 2024

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Sep 15, 2024

Fixes #841
Fixes #1009
Fixes #1180
Fixes #1181
Fixes #1185

  1. Adds a detached state for managers. Callers with those managers will first be aware of the detaching state before any actual calls to avoid crashes.
  2. Errors replied by the channel do not include detailed messages before. Now the code will unwrap certain exceptions to extract details from them.
  3. PHAssetResource with the type PHAssetResourceTypeFullSizeVideo does not count as a video type before, making the resource obtain ignore them.
  4. Fixes potential range exception when converting NSTimeInterval on Darwin.
  5. Fixes progress not being updated when getting the non-original video file on iOS.
  6. Fixes incorrect Live Photo resource being obtained which will result in a wrong aspect ratio.
  7. Fixes Live Photos saving exceptions with the paired video.
  8. Expose progressHandler for AssetEntity.getMediaUrl.
  9. Expose withSubtype for AssetEntity.isLocallyAvailable to request if a Live Photo resource is available.
  10. Other lints and type promotion fixes.

Copy link

Download apk from here for efd0ffc

Copy link

Download apk from here for 54eeebd

Copy link

Download apk from here for a779b8e

Copy link

Download apk from here for e96823e

Copy link

Download apk from here for ac32efa

Copy link

Download apk from here for 183872b

@AlexV525 AlexV525 marked this pull request as ready for review September 22, 2024 06:37
Copy link

Download apk from here for d536e70

Copy link

Download apk from here for b9ec484

@AlexV525 AlexV525 merged commit 60037ba into main Sep 22, 2024
13 checks passed
@AlexV525 AlexV525 deleted the feat/improvements branch September 22, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant