feat: get current permission #1184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
Signed-off-by: Caijinglong <[email protected]>
AlexV525
reviewed
Sep 15, 2024
| } | ||
| } | ||
|
|
||
| - (void)getPermissionState:(ResultHandler *)handler { | ||
| int requestAccessLevel = [handler.call.arguments[@"iosAccessLevel"] intValue]; | ||
| #if __IPHONE_14_0 |
There was a problem hiding this comment.
Is the macro required? The minimum Xcode has already supported at least iOS 17.
| @@ -63,7 +63,7 @@ enum OrderOptionType { | |||
| enum PMRequestState { prepare, loading, success, failed } | |||
|
|
|||
| /// Information about app’s authorization to access the user’s photo library. | |||
| /// * Android: Only [authorized] and [denied] are valid. | |||
| /// * Android: Have [authorized], [denied] and [limited] | |||
There was a problem hiding this comment.
Suggested change
| /// * Android: Have [authorized], [denied] and [limited] | |
| /// * Android: [authorized], [denied], and [limited]. |
| PMConstants.mGetPermissionState, | ||
| requestOption.toMap(), | ||
| ); | ||
| return PermissionState.values[result ?? 0]; |
There was a problem hiding this comment.
Is there any chance that we can get a nullable result here? If not, use the non-nullable return.
Comment on lines
+60
to
+82
| /// Get the current permission state of the application | ||
| /// | ||
| /// This method returns a [Future] that resolves to the current [PermissionState] of the application. | ||
| /// | ||
| /// Possible values for [PermissionState] include: | ||
| /// - [PermissionState.notDetermined]: The user hasn't made a choice yet | ||
| /// - [PermissionState.restricted]: The application is restricted from accessing the photo library (iOS only) | ||
| /// - [PermissionState.denied]: The user has denied permission | ||
| /// - [PermissionState.authorized]: The user has granted full access permission | ||
| /// - [PermissionState.limited]: The user has granted limited access permission (iOS 14+ only) | ||
| /// | ||
| /// Example: | ||
| /// ```dart | ||
| /// PermissionState state = await PhotoManager.getPermissionState(); | ||
| /// if (state == PermissionState.authorized) { | ||
| /// print('The application has full access permission'); | ||
| /// } else { | ||
| /// print('The application does not have full access permission'); | ||
| /// } | ||
| /// ``` | ||
| /// | ||
| /// Note: On Android, this method may require an [Activity] context. If called in a background service, | ||
| /// make sure to call the [setIgnorePermissionCheck] method first. |
There was a problem hiding this comment.
Suggested change
| /// Get the current permission state of the application | |
| /// | |
| /// This method returns a [Future] that resolves to the current [PermissionState] of the application. | |
| /// | |
| /// Possible values for [PermissionState] include: | |
| /// - [PermissionState.notDetermined]: The user hasn't made a choice yet | |
| /// - [PermissionState.restricted]: The application is restricted from accessing the photo library (iOS only) | |
| /// - [PermissionState.denied]: The user has denied permission | |
| /// - [PermissionState.authorized]: The user has granted full access permission | |
| /// - [PermissionState.limited]: The user has granted limited access permission (iOS 14+ only) | |
| /// | |
| /// Example: | |
| /// ```dart | |
| /// PermissionState state = await PhotoManager.getPermissionState(); | |
| /// if (state == PermissionState.authorized) { | |
| /// print('The application has full access permission'); | |
| /// } else { | |
| /// print('The application does not have full access permission'); | |
| /// } | |
| /// ``` | |
| /// | |
| /// Note: On Android, this method may require an [Activity] context. If called in a background service, | |
| /// make sure to call the [setIgnorePermissionCheck] method first. | |
| /// Get the current [PermissionState] of the photo library. | |
| /// | |
| /// Example: | |
| /// ```dart | |
| /// PermissionState state = await PhotoManager.getPermissionState(); | |
| /// if (state == PermissionState.authorized) { | |
| /// print('The application has full access permission'); | |
| /// } else { | |
| /// print('The application does not have full access permission'); | |
| /// } | |
| /// ``` | |
| /// | |
| /// Note: On Android, this method may require an [Activity] context. | |
| /// Call [setIgnorePermissionCheck] first if the call is from a background service. |
Comment on lines
+65
to
+69
| /// - [PermissionState.notDetermined]: The user hasn't made a choice yet | ||
| /// - [PermissionState.restricted]: The application is restricted from accessing the photo library (iOS only) | ||
| /// - [PermissionState.denied]: The user has denied permission | ||
| /// - [PermissionState.authorized]: The user has granted full access permission | ||
| /// - [PermissionState.limited]: The user has granted limited access permission (iOS 14+ only) |
There was a problem hiding this comment.
We could state these values in the enum definition.
Comment on lines
+83
to
+85
| static Future<PermissionState> getPermissionState({ | ||
| PermissionRequestOption requestOption = const PermissionRequestOption(), | ||
| }) { |
There was a problem hiding this comment.
Could we make requestOption as a required named parameter? In that way we let developers always have a sense of what they are trying to do and provide valid input.
| values.add('audio'); | ||
| } | ||
|
|
||
| return '$runtimeType(${values.join(', ')})'; |
There was a problem hiding this comment.
Suggested change
| return '$runtimeType(${values.join(', ')})'; | |
| return 'RequestType(${values.join(', ')})'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.