🚀 Apply detaching more gracefully

fluttercandies · Sep 18, 2024 · 1e9964d · 1e9964d
1 parent e13c362
commit 1e9964d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/ios/Classes/PMNotificationManager.m b/ios/Classes/PMNotificationManager.m
@@ -12,6 +12,10 @@ @implementation PMNotificationManager {
     BOOL isDetach;
 }
 
+- (void)dealloc {
+    [self detach];
+}
+
 - (instancetype)initWithRegistrar:
     (NSObject <FlutterPluginRegistrar> *)registrar {
     self = [super init];

diff --git a/ios/Classes/PMPlugin.m b/ios/Classes/PMPlugin.m
@@ -34,18 +34,19 @@ - (void)registerPlugin:(NSObject <FlutterPluginRegistrar> *)registrar {
     }];
 }
 
-- (void)dealloc {
+- (void)detach {
     privateRegistrar = nil;
     isDetach = YES;
     [channel setMethodCallHandler:nil];
     [self.notificationManager detach];
 }
 
+- (void)dealloc {
+    [self detach];
+}
+
 - (void)applicationWillTerminate:(NSNotification *)notification {
-    privateRegistrar = nil;
-    isDetach = YES;
-    [channel setMethodCallHandler:nil];
-    [self.notificationManager detach];
+    [self detach];
 }
 
 - (void)initNotificationManager:(NSObject <FlutterPluginRegistrar> *)registrar {