Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pubspec support for survey validator #106

Merged
merged 7 commits into from
Sep 14, 2023

Conversation

eliasyishak
Copy link
Contributor

This PR adds a new key to the json file to restrict certain dash tools from receiving surveys. It also uses the typical dart console structure so that we can import package:unified_analytics to get the list of valid dash tools

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@eliasyishak eliasyishak marked this pull request as ready for review September 13, 2023 17:44
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

surveys/survey-validator/pubspec.yaml Outdated Show resolved Hide resolved
surveys/survey-validator/pubspec.yaml Outdated Show resolved Hide resolved
surveys/survey-validator/lib/survey_validator.dart Outdated Show resolved Hide resolved
@eliasyishak eliasyishak merged commit 787d5ed into master Sep 14, 2023
5 checks passed
@eliasyishak eliasyishak deleted the restrict-surveys-by-dashtool branch September 14, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants