-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[go_router] Fix Android Cold Start deep link with empty path losing scheme and authority. #9868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[go_router] Fix Android Cold Start deep link with empty path losing scheme and authority. #9868
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -575,10 +575,7 @@ class GoRouter implements RouterConfig<RouteMatchList> { | |||
if (platformDefaultUri.hasEmptyPath) { | |||
// TODO(chunhtai): Clean up this once `RouteInformation.uri` is available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this todo is obsolete now, can you remove this todo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted in the commit below!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hannah-hyj @chunhtai |
Description
Fixes an issue where deep links with empty paths (e.g.,
https://example.com
) lose their scheme and authority information during Android Cold Start.This PR fixes flutter/flutter#174249
Detailed reproduction steps, environment information, and code sample are provided in the linked issue.
Problem
On Android Cold Start, if the initial deep link has no path (
https://example.com
),_effectiveInitialLocation
incorrectly creates a newUri
with only/?
instead of preserving scheme and authority.This results in the router receiving a relative path instead of the full deep link URL.
Solution
Use
Uri.replace(path: '/')
instead of creating a newUri
, so that the original scheme and authority are preserved.Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assist
bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3