Skip to content

[video_player_avfoundation] Fix regression where http headers were ignored #10991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbcorona wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

[video_player_avfoundation] Fix regression where http headers were ignored #10991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/video_player/video_player_avfoundation/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.9.3

* Fixes a regression where HTTP headers were ignored.

## 2.9.2

* Refactors for improved testability.
Expand Down
2 changes: 1 addition & 1 deletion ...ndation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPAVFactory.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ - (BOOL)setCategory:(AVAudioSessionCategory)category
@implementation FVPDefaultAVFactory
- (NSObject<FVPAVAsset> *)URLAssetWithURL:(NSURL *)URL
options:(nullable NSDictionary<NSString *, id> *)options {
return [[FVPDefaultAVAsset alloc] initWithAsset:[AVAsset assetWithURL:URL]];
return [[FVPDefaultAVAsset alloc] initWithAsset:[AVURLAsset URLAssetWithURL:URL options:options]];
Copy link

@gemini-code-assist gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change correctly resolves the regression by using AVURLAsset URLAssetWithURL:options: instead of AVAsset assetWithURL:. This ensures that HTTP headers are properly passed to the asset, which is a critical fix for the player's functionality when dealing with authenticated or custom header-dependent streams.

}

- (NSObject<FVPAVPlayerItem> *)playerItemWithAsset:(NSObject<FVPAVAsset> *)asset {
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player_avfoundation/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_avfoundation
description: iOS and macOS implementation of the video_player plugin.
repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player_avfoundation
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.9.2
version: 2.9.3

environment:
sdk: ^3.10.0
Expand Down
Loading