fix: parse adjacency-list values for non-root paths #712
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `DataModel.update`, `_parseDataModelContents` was only called when the path was the root. For non-root paths, this caused a TypeError when a widget subscribed to that path expecting a map since the stored value was still the raw A2UI adjacency list format.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the issue of parsing adjacency-list values for non-root paths by introducing a parsedContents variable. This ensures that list-based content is correctly transformed into a map structure before being applied to the data model, whether at the root or a nested path. The addition of a dedicated test case for non-root path parsing further validates the fix and improves test coverage. The changes are clear, concise, and directly resolve the reported problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #710. That issue has a detailed technical breakdown, so I won't duplicate one here.
Pre-launch Checklist
///).