Bootstrap the Flutter IJ with integrations tests #8487
Conversation
jwren
force-pushed
the
integration_tests_05
branch
3 times, most recently
from
e5d908a to
720e408
Compare
jwren
added
🤖 AI-assisted
jwren
force-pushed
the
integration_tests_05
branch
from
720e408 to
2494c6c
Compare
testSrc/integration/io/flutter/integrationTest/NewProjectUITest.kt
Outdated
Show resolved
Hide resolved
| class MyProjectUITest { | ||
|
|
||
| companion object { | ||
| // Generate a unique folder name for the test project to avoid conflicts |
There was a problem hiding this comment.
This seems like an odd place for the comment. It feels like it should be in initContext. (Unless you want to say: "this will be updated to a unique folder name..."
testSrc/integration/io/flutter/integrationTest/utils/NewProject.kt
Outdated
Show resolved
Hide resolved
The additional STARTER test framework is added, see https://github.com/JetBrains/intellij-ide-starter Thanks to others here who trailblazed, @jonathan1983, JetBrains/intellij-platform-plugin-template#537 and @helinx, flutter#8338 The change does not try to get the new tests working in the presubmit.
jwren
force-pushed
the
integration_tests_05
branch
from
1d21155 to
d041a13
Compare
| * found in the LICENSE file. | ||
| */ | ||
|
|
||
| package io.flutter.integrationTest |
There was a problem hiding this comment.
Sorry, missed this before. but the standard practice is to keep package names all lowercase. See:
https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html
There was a problem hiding this comment.
Can you address this in a follow-up?
There was a problem hiding this comment.
Resolving in a follow up PR.
| return setupTestContext( | ||
| "", IdeProductProvider.IC.copy( | ||
| // TODO(team) should the version be fetched from some setting, i.e. System.getProperty("uiPlatformBuildVersion") | ||
| buildNumber = "252.23892.409", |
There was a problem hiding this comment.
Can we inject from build.gradle.kts and/or from the gradle.properties file?
There was a problem hiding this comment.
You can. In the task setup in the gradle configuration file you pass the gradle property along as a JVM property. resolving these TODOs as well as threading through the dart plugin version as a follow up.
|
|
||
| @Test | ||
| @Disabled("Need license configuration to test") | ||
| fun newProjectWS() { |
There was a problem hiding this comment.
Would it make sense to call this something like testNewProjectWS? Maybe this is unnecessary with the annotation, but I find it hard to know where the test originates.
There was a problem hiding this comment.
Following up with another PR
The additional STARTER test framework is added, see https://github.com/JetBrains/intellij-ide-starter
Thanks to others here who trailblazed, @jonathan1983, JetBrains/intellij-platform-plugin-template#537 and @helinx, #8338