Pre-format licenses script #57219
Merged
Pre-format licenses script #57219
+1,943
−1,311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
commented
Dec 16, 2024
ci/licenses_golden/licenses_dart
Outdated
| @@ -4807,7 +4807,7 @@ Exhibit B - "Incompatible With Secondary Licenses" Notice | |||
| This Source Code Form is "Incompatible With Secondary Licenses", as | |||
| defined by the Mozilla Public License, v. 2.0. | |||
|
|
|||
| You may obtain a copy of this library's Source Code Form from: https://dart.googlesource.com/sdk/+/770ff2b085fc4a2992c8f085e5654b11da336555 | |||
| You may obtain a copy of this library's Source Code Form from: https://dart.googlesource.com/sdk/+/02aa27c6a075f33b9ea0551b192ad28aef74fbd1 | |||
There was a problem hiding this comment.
It's not super-clear to me why this diff is surfacing in this PR. In theory, this should have been updated as part of the Dart SDK roll in #57161. Other Dart SDK rolls have updated this line as expected (example: #57159). So, unclear, why that particular roll didn't.
cc @jonahwilliams FYI (you were listed as the contact point for the roll in question)
goderbauer
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/57219, due to Pull request flutter/engine/57219 is not in a mergeable state. |
goderbauer
added
the
autosubmit
goderbauer
force-pushed
the
licenseFormat
branch
from
8579b91 to
af01553
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 17, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 17, 2024
…160399) flutter/engine@1d2eb3f...90c9185 2024-12-17 [email protected] Pre-format licenses script (flutter/engine#57219) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
The license script has load-baring formatting: Changing its format makes signature checks fail. To ensure the formatting change goes in smoothly later this week I am taking it off the critical path by pre-formatting it. The script itself is fairly stable, so I am not expecting any changes to it between now and when we actually enforce formatting. Edit: The issue that surfaced with `ci/licenses_golden/licenses_dart` is another reason to take this off the critical path of enforcing formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The license script has load-baring formatting: Changing its format makes signature checks fail. To ensure the formatting change goes in smoothly later this week I am taking it off the critical path by pre-formatting it.
The script itself is fairly stable, so I am not expecting any changes to it between now and when we actually enforce formatting.
Edit: The issue that surfaced with
ci/licenses_golden/licenses_dartis another reason to take this off the critical path of enforcing formatting.