Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Switch to uniform arrays for gradient data on non-SSBO hardware #56441

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

flar
Copy link
Contributor

@flar flar commented Nov 7, 2024

Currently the most generalized form of the Impeller gradient shaders uses an SSBO to store the gradient information, but SSBO data is not supported on older platforms. To make the capability more general we introduce variants of the gradient shaders that uses uniform arrays which are more widely supported.

@flar flar force-pushed the impeller-uniforms-for-general-gradients-2 branch from 73980eb to 46ae8aa Compare November 7, 2024 22:47
@flar flar marked this pull request as ready for review November 7, 2024 23:55
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #56441 at sha 46ae8aa

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #56441 at sha b99aa78

@flar
Copy link
Contributor Author

flar commented Nov 8, 2024

The goldens all make sense to me:

  • The 12 new images from the new test I added
  • All the rest of the tests are restricted to the OpenGLES platform:
    • A whole bunch of off-by-1-color-component
    • A couple of off-by-3ish color component cases
    • A couple of off-by-1-pixel on the edges of some sweep gradients
    • One case of an actual bug fix for the overlapping stops test case now handled correctly by the new shader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant