[iOS] Fix slider semantics node answer to accessibility activate #56427
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroux
force-pushed
the
fix_ios_slider_semantics_node
branch
from
a821ba0
to
5275592
Compare
chunhtai
approved these changes
Nov 7, 2024
| @@ -692,6 +692,9 @@ - (BOOL)accessibilityActivate { | |||
| return NO; | |||
| } | |||
| if (!self.node.HasAction(flutter::SemanticsAction::kTap)) { | |||
| if (self.node.HasFlag(flutter::SemanticsFlags::kIsSlider)) { | |||
There was a problem hiding this comment.
Can you add a comment explain the reasoning?
bleroux
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
iOS fix [A11y] Double Tap brings the Slider thumb to the center of the widget. per instruction from flutter/flutter#157601 (comment)
I don't have a physical iOS device to double check, but using the iOS Simulator and accessibility tools, the behavior seems ok. Without this PR, the slider thumb goes to the center when clicking 'Activate', with this PR it does not :
Enregistrement.de.l.ecran.2024-11-07.a.11.09.01.mov
Related Issue
iOS fix for [A11y] Double Tap brings the Slider thumb to the center of the widget.
Tests
Adds 1 test.